Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dropdown list item spacing and a couple minor spacing corrections #2140

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Fix dropdown list item spacing and a couple minor spacing corrections #2140

merged 1 commit into from
Jul 24, 2019

Conversation

sg00dwin
Copy link
Member

Issues addressed
• Dropdown-menu-items height was incorrect.
• Reduce spacing between row heading and row to match pairs-list
• Remove icon css was no longer needed.
• Restructure css to remove nesting and follow bem structure

Before
Screen Shot 2019-07-23 at 1 20 09 PM

Screen Shot 2019-07-23 at 3 32 33 PM

After

Screen Shot 2019-07-23 at 3 11 34 PM

Screen Shot 2019-07-23 at 3 35 26 PM

@sg00dwin sg00dwin requested a review from rhamilto July 23, 2019 19:44
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 23, 2019
rhamilto
rhamilto reviewed Jul 23, 2019
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 23, 2019
@spadgett
Copy link
Member

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 23, 2019
@spadgett spadgett added this to the v4.2 milestone Jul 23, 2019
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 23, 2019
@sg00dwin sg00dwin force-pushed the taints-tolerations-dropdown-bug branch from b024dad to 317d15e Compare July 24, 2019 14:09
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 24, 2019
@rhamilto
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1c78f00 into openshift:master Jul 24, 2019
@sg00dwin sg00dwin deleted the taints-tolerations-dropdown-bug branch August 19, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto left review comments

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

Assignees

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@sg00dwin @spadgett @rhamilto @openshift-ci-robot @openshift-merge-robot